Repository navigation
feat(WO20): exhaustive per-row tests for the eight thin odni maps (coverage depth, batch 1) - #287
Merged
Merged
Conversation
…verage depth) The full letter tables of ICS 630-01 Annexes Q/P/R/S/N/U/C/H are transcribed from the held source PDFs into row-source provenance artifacts and generated into embedded tests with scripts/gen-row-tests.mjs. No map rules changed. 314 rows transcribed, all passing end-to-end; 15 skipped printed rows and 11 source-anchored findings documented in the artifacts (kaz "Ya" case slip; tgk е footnote semantics + see-Russian cells; che palochka findings incl. missing plain-ц rule and unimplemented footnotes 1/3; mkd dze: Latin S/s encoded instead of Ѕ/ѕ).
ronaldtse
added a commit
that referenced
this pull request
Nov 16, 2026
Three batches from held sources (maps #287/#288/#289): eight odni ICS-630 maps, eight thinnest DIN 1460-2 maps, six small ALA-LC tables - 906 exhaustive per-row tests, all verified end-to-end; 48 source-anchored findings recorded for follow-up fixes. Golden refreshed additively (rs #30): 13,745 rows, zero lost/changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WO20 coverage-depth, batch 1 of the corpus audit (#283): the eight thin ODNI maps. The full letter tables of the ICS 630-01 annexes are transcribed from the held source PDFs (
interscript-private-references/ics-630-01/) into row-source provenance artifacts, generated into embedded tests withscripts/gen-row-tests.mjs(the #272/#281 pattern). No map rules changed — the tests pin the maps against the printed tables; divergences are findings recorded in the artifacts and below.Audit (corpus-wide rank, tests vs encoded rule table, ascending)
Method: per map, embedded-test count vs
sub-rule count; the machine-expanded CJK/jamo tables (10k+ rules) are excluded as not letter-table-shaped. Top thin maps with locally-held sources:Per-map counts (transcribed = generated; every generated test passes)
Multi-key value cells ("и, і"; "г, ҝ"; "й, ј"; "у, ү"; "|, ӏ, 1"; mkd case-pair cells) are transcribed as one row per printed key. Every value cell was verified against the rendered page image; the annexes' text layers store lookalike Cyrillic glyphs for printed Latin e/x, documented per artifact.
Findings (source-anchored; maps untouched this round)
Gates
iscrs test-all --maps maps(branch corpus): 11,985 passed, 0 failed (the eight maps: 324 tests)iscrs capture --root mapsvs interscript-rstests/golden/isc-wf0.jsonl): 0 lost, 0 changed; +770 uncaptured rows — +315 odni (this batch's 314 generated rows + 1 pre-existing hand-test row), +450 from the feat(WO17): exhaustive per-row test generator; alalc-vai 240-row demonstration #272/feat(WO19): exhaustive per-row tests for alalc-hye/zgh/chr (conformance depth) #281 vai/hye/zgh/chr generated rows, +5 pre-existing singles on main (bel/rus BS-2979 era). The rs golden is not touched here (maps-side PRs only per the WO20: corpus coverage audit + conformance-depth batches from held sources #283 coordination); a single rs golden-recapture PR will cover all WO20 batches.Test plan
iscrs transliteratebefore being written into the artifactiscrs test-allgreen on the branch corpus (11,985/0)scripts/row-sources/*.jsonnote